Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.gtts: init at 2.1.1 #81149

Merged
merged 1 commit into from Feb 29, 2020
Merged

pythonPackages.gtts: init at 2.1.1 #81149

merged 1 commit into from Feb 29, 2020

Conversation

unode
Copy link
Member

@unode unode commented Feb 26, 2020

Motivation for this change

This package is also needed to fix the mnemosyne runtime errors mentioned in #80924

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@unode
Copy link
Member Author

unode commented Feb 26, 2020

@ofborg build python37Packages.gtts

@unode
Copy link
Member Author

unode commented Feb 27, 2020

Similarly to the recent #80430 , tests in this package also mostly call out to Google's Translate API.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit msg should be:

pythonPackages.gtts: init at 2.1.1

@unode
Copy link
Member Author

unode commented Feb 27, 2020

My bad, fixed now.

@unode unode changed the title gtts: init at 2.1.1 pythonPackages.gtts: init at 2.1.1 Feb 27, 2020
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

https://github.com/NixOS/nixpkgs/pull/81149
2 package built:
python37Packages.gtts python38Packages.gtts

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.gtts python38Packages.gtts

@jonringer jonringer merged commit 71113db into NixOS:master Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants