Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/git-daemon: only create git user if it will be used #81118

Merged
merged 1 commit into from Mar 1, 2020

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Feb 26, 2020

Motivation for this change

This was broken in 1d61efb, but it doesn't make sense to create the git user iff it will not be used.

A fix for this regression needs to be backported to 20.03.

I added a test that passes with this PR, and would fail without it. It's my first test, let me know if I did something wrong.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg test gitdaemon

@worldofpeace worldofpeace merged commit 21c971a into NixOS:master Mar 1, 2020
@worldofpeace
Copy link
Contributor

Thanks @tilpner ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants