Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

megasync: 4.2.3.0 -> 4.3.0.8 #81117

Merged
merged 3 commits into from Mar 16, 2020
Merged

megasync: 4.2.3.0 -> 4.3.0.8 #81117

merged 3 commits into from Mar 16, 2020

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Feb 26, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Synthetica9
megasync: format with nixfmt
5e55ebb
@Synthetica9
megasync: 4.2.3.0 -> 4.2.5.0
080a6b0 
Also pull in an (as of yet unmerged) upstream patch to fix
the build, it was failing on both .3 and .5
@ofborg ofborg bot requested a review from michojel February 26, 2020 13:10
@thefloweringash thefloweringash mentioned this pull request Mar 1, 2020
Closed
10 tasks
@Mathnerd314
Copy link
Contributor

4.3.0 is out, that would be better.

@Synthetica9 Synthetica9 changed the title megasync: 4.2.3.0 -> 4.2.5.0 megasync: 4.2.3.0 -> 4.3.0.8 Mar 10, 2020
michojel
michojel approved these changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@michojel michojel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and works for me as well. Thanks!

@michojel
Copy link
Contributor

@GrahamcOfBorg build megasync

@michojel
Copy link
Contributor

@markuskowa may I kindly ask you for your brief check and/or merge?

@markuskowa markuskowa merged commit 1b5ef3f into NixOS:master Mar 16, 2020
@michojel
Copy link
Contributor

Thanks to all involved.

@michojel michojel mentioned this pull request Mar 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michojel michojel michojel approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Synthetica9 @Mathnerd314 @michojel @markuskowa