Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: 1.3.118 -> 1.4.95 #81076

Merged
merged 1 commit into from Feb 27, 2020
Merged

brave: 1.3.118 -> 1.4.95 #81076

merged 1 commit into from Feb 27, 2020

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Feb 26, 2020 •
edited

Motivation for this change
Things done

Updated the checksum and the version of brave

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from rht and uskudnik February 26, 2020 01:14
@rht
Copy link
Member

rht commented Feb 26, 2020

LGTM

@JeffLabonte JeffLabonte mentioned this pull request Feb 26, 2020
Merged
10 tasks
@JeffLabonte
Copy link
Contributor Author

JeffLabonte commented Feb 27, 2020 •
edited

@rht Would it be possible to approve the PR? :)

@rht
Copy link
Member

rht commented Feb 27, 2020

@JeffLabonte approved.

cole-h
cole-h approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Appears to work fine (though as I don't use brave as a daily-driver can't comment on much more).

[3 built, 20 copied (52.1 MiB), 14.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81076
1 package built:
brave

@etu etu merged commit 9874d5f into NixOS:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rht rht rht approved these changes

@cole-h cole-h cole-h approved these changes

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JeffLabonte @rht @cole-h @etu