Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] discord: 0.0.9 -> 0.0.10 #81052

Merged
merged 3 commits into from Feb 26, 2020
Merged

[20.03] discord: 0.0.9 -> 0.0.10 #81052

merged 3 commits into from Feb 26, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 25, 2020 •
edited

Motivation for this change

backport of #81050 #81044

essentially app is unusable (on NixOS) unless the latest version is used

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[7 built, 120 copied (376.6 MiB), 80.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81052
3 package built:
discord discord-canary discord-ptb

kraem and others added 3 commits February 25, 2020 12:49
@kraem @jonringer
discord: 0.0.9 -> 0.0.10
7a20cc8 
(cherry picked from commit 3ec9925)
@jonringer
discord-ptb: 0.0.16 -> 0.0.18
7a79f04 
(cherry picked from commit e1d05e3)
@jonringer
discord-canary: 0.0.98 -> 0.0.102
ed25c96 
(cherry picked from commit da5e340)
@jonringer jonringer changed the title Backport discord 20.03 [20.03] discord: 0.0.9 -> 0.0.10 Feb 25, 2020
@jonringer jonringer requested review from shyim, kraem and tadeokondrak and removed request for shyim February 25, 2020 21:03
@jonringer jonringer merged commit fb21184 into NixOS:release-20.03 Feb 26, 2020
@jonringer jonringer deleted the backport-discord-20.03 branch February 26, 2020 00:40
@jonringer jonringer mentioned this pull request Feb 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyim shyim shyim approved these changes

@kraem kraem Awaiting requested review from kraem

@tadeokondrak tadeokondrak Awaiting requested review from tadeokondrak

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @shyim @kraem