libyamlcpp: actually build shared libraries #81051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks nixpkgs/pkgs/stdenv/adapters.nix Line 63 in 3a0da44 I propose a slightly different solution diff --git a/pkgs/development/libraries/libyaml-cpp/default.nix b/pkgs/development/libraries/libyaml-cpp/default.nix
index 0dec9daee6a..68d2241b243 100644
--- a/pkgs/development/libraries/libyaml-cpp/default.nix
+++ b/pkgs/development/libraries/libyaml-cpp/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchFromGitHub, cmake }:
+{ stdenv, fetchFromGitHub, fetchpatch, cmake }:
stdenv.mkDerivation rec {
pname = "libyaml-cpp";
@@ -11,6 +11,13 @@ stdenv.mkDerivation rec {
sha256 = "0ykkxzxcwwiv8l8r697gyqh1nl582krpvi7m7l6b40ijnk4pw30s";
};
+ # implement https://github.com/jbeder/yaml-cpp/commit/52a1378e48e15d42a0b755af7146394c6eff998c
+ postPatch = ''
+ substituteInPlace CMakeLists.txt \
+ --replace 'option(YAML_BUILD_SHARED_LIBS "Build Shared Libraries" OFF)' \
+ 'option(YAML_BUILD_SHARED_LIBS "Build yaml-cpp shared library" ''${BUILD_SHARED_LIBS})'
+ '';
+
outputs = [ "out" "dev" ];
nativeBuildInputs = [ cmake ]; |
lopsided98
force-pushed
the
libyamlcpp-shared
branch
from
bd90015
to
c31540d
Compare
|
Fixed. |
veprbl
pushed a commit
that referenced
this pull request
Feb 29, 2020
(cherry picked from commit be41f70)
veprbl
added
the
8.has: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This package uses a custom CMake variable to enable shared libraries, rather
than the standard
BUILD_SHARED_LIBS.All dependent packages build successfully except for
ip2unixandscylladb(which was not built by nixpkgs-review for some reason in my last PR), both of which currently fail on master.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @andir