Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] pythonPackages.fipy: 3.3 -> 3.4.1 #81041

Merged
merged 1 commit into from Feb 26, 2020
Merged

[20.03] pythonPackages.fipy: 3.3 -> 3.4.1 #81041

merged 1 commit into from Feb 26, 2020

Conversation

wd15
Copy link
Contributor

@wd15 wd15 commented Feb 25, 2020 •
edited

Motivation for this change

Fix fipy, which is breaking in Hydra

  • Required a version bump to fix compatibility with Numpy version
  • Required openssh to fix tests.
  • Using fetchurl rather than fetchPypi, which is preferred now

For ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wd15
Copy link
Contributor Author

wd15 commented Feb 25, 2020

Result of nix-review pr 81041 1

3 package were built:
  • python27Packages.fipy
  • python37Packages.fipy
  • python38Packages.fipy

@ofborg ofborg bot requested a review from costrouc February 25, 2020 19:06
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 26, 2020

@GrahamcOfBorg build pythonPackages.fipy python3Packages.fipy

@rnhmjoj rnhmjoj merged commit ef54b60 into NixOS:release-20.03 Feb 26, 2020
@wd15 wd15 deleted the fipy-3.4.1 branch February 26, 2020 15:08
@rnhmjoj rnhmjoj mentioned this pull request Feb 28, 2020
Closed
10 tasks
@wd15 wd15 mentioned this pull request Feb 28, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wd15 @rnhmjoj