noweb: fix installation of manpages, use placeholders #81042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
KoviRobi
changed the title
|
Awesome, thank you! |
yurrriq
approved these changes
Feb 26, 2020
This was referenced Mar 1, 2020
Merged
KoviRobi
force-pushed
the
zhf-20.03-fix-noweb
branch
from
c342d8a
to
9b2b6ec
Compare
The problem was that nix passes lists as space-separated strings not as
arrays of strings, so `"${foo[@]}"` doesn't work as intended because
it's not an array. Instead we pass it in a bash array.
Also, using builtins.placeholder instead of passing "$(out)" to bash, as
that's not what we want to do (the `$(...)` is the process expansion in
bash)
KoviRobi
force-pushed
the
zhf-20.03-fix-noweb
branch
from
9b2b6ec
to
d68dfbb
Compare
KoviRobi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that nix passes lists as space-separated strings not as
arrays of strings, so
"${foo[@]}"doesn't work as intended becauseit's not an array.
Also, using builtins.placeholder instead of passing "$(out)" to bash, as
that's not what we want to do. (As in bash "$(...)" is shell expansion, unsure if that worked at all.)
Motivation for this change
(This was ZHF: #80379 but a different PR resolved that, though it doesn't now install man-pages. This fixes that.)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)