Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break-spaces-05[1-2].html and its reference #21963

Merged
merged 4 commits into from Mar 25, 2020
Merged

break-spaces-05[1-2].html and its reference #21963

merged 4 commits into from Mar 25, 2020

Conversation

TalbotG
Copy link
Contributor

@TalbotG TalbotG commented Feb 25, 2020

2 tests with inline starting with a collapsible white space

break-spaces-051.html
break-spaces-052.html
reference/ref-filled-green-100px-square.xht

@TalbotG TalbotG assigned frivoal and unassigned plinss Feb 25, 2020
@TalbotG TalbotG changed the title Css3 text gt pr5 break-spaces-05[1-2].html and its reference Feb 25, 2020
frivoal
frivoal approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@frivoal frivoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a small change to reuse rather than duplicate the green square ref, but other than that, all good. Approved.

@TalbotG TalbotG merged commit 9e6e7af into web-platform-tests:master Mar 25, 2020
@TalbotG TalbotG deleted the CSS3Text-GT-PR5 branch March 25, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frivoal frivoal frivoal approved these changes

@fantasai fantasai Awaiting requested review from fantasai

@kojiishi kojiishi Awaiting requested review from kojiishi

@nox nox Awaiting requested review from nox

@plinss plinss Awaiting requested review from plinss

@r12a r12a Awaiting requested review from r12a

Assignees

@frivoal frivoal

Labels
css-text
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TalbotG @frivoal @plinss @wpt-pr-bot