Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/kresd: never force extraFeatures = false #81122

Merged
merged 1 commit into from Feb 26, 2020

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Feb 26, 2020

Fixes #81109. Regressed in PR #78392 (2685806).

@vcunat vcunat added 6.topic: nixos 9.needs: port to stable A PR needs a backport to the stable release. 0.kind: regression Something that worked before working no longer labels Feb 26, 2020
@vcunat vcunat requested a review from Mic92 February 26, 2020 14:16
@vcunat
Copy link
Member Author

vcunat commented Feb 26, 2020

I think this simple fix is clear, but I'll wait a couple days for feedback anyway.

@Mic92 Mic92 merged commit 8e1350e into NixOS:master Feb 26, 2020
@vcunat vcunat deleted the p/kresd-extraFeatures branch February 26, 2020 16:21
vcunat pushed a commit that referenced this pull request Feb 26, 2020
@vcunat vcunat added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: regression Something that worked before working no longer 6.topic: nixos 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nixos/knot-resolver: extraFeatures depends on listenDoH, awkward to workaround
2 participants