New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tensorflow (1.15.1) to work with glibc 2.3 and bazel_1 #81035
Conversation
@andir, for some reason the SHA doesn't mismatch when I try to build without CUDA. I had to update it after the glibc patch though. Edit: Fixed |
You mean the fixed output hash doesn't mismatch? You will have to invalidate it manually (once). |
I just tried building this with a new machine and for some reason it looks like the patch isn't being applied. Update: Fixed |
Ok, this PR should be gtg pending merging of #81033 and allowing bazelBuild to select the variant of bazel to use. |
@andir I updated build-bazel-package to take a specific version of bazel, defaults to bazel, but will updated to bazel_1 after the other PR is merged, not sure if this is the best way to go... |
}: | ||
|
||
args@{ | ||
name | ||
, bazelVersion ? bazel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think bazelVerson
gives the wrong hint (is it a string?). How about going with just bazel
?
I've done the same change in e5d8d31
I like sticking to just bazel
as that is the package name and is more intuitive for users already knowing the standard .override { }
mechanism.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, I think this now matches your implementation?
d429d9c
to
e98e8b5
Compare
fd1b632
to
30f24e9
Compare
please rebase now that bazel_1 is in. |
30f24e9
to
435cf89
Compare
@FRidh done. |
Also, commit names need to follow our guidelines. |
435cf89
to
e0b6c41
Compare
* Apply glibc 2.3 patch * build tensorflow with bazel_1 * Bump openssl version to 1.1
e0b6c41
to
1dc0db8
Compare
@FRidh fixed? The version bump isn't the primary purpose of this PR, but ended up being necessary for the glibc patch to work. |
Motivation for this change
Fixes #77771, blocked by #81033
Things done
Add patch to grpc to allow building tensorflow with glibc > 2.3.0
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)