Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] brave: 1.3.118 -> 1.4.95 #81082

Merged
merged 1 commit into from Mar 4, 2020
Merged

[20.03] brave: 1.3.118 -> 1.4.95 #81082

merged 1 commit into from Mar 4, 2020

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Feb 26, 2020 •
edited

brave: 1.3.118 -> 1.4.95

(cherry picked from commit fa166b7)
Reason: Browser should be kept up-to-date for security reasons.

Motivation for this change
Things done

This PR backports #81076

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JeffLabonte JeffLabonte force-pushed the release/20.03-brave_1.3.118_to_1.4.95 branch 2 times, most recently from edf9d67 to 50d2d4a Compare February 26, 2020 02:18
@ofborg ofborg bot requested review from rht and uskudnik February 26, 2020 02:29
@worldofpeace
Copy link
Contributor

See #81078

@JeffLabonte
brave: 1.3.118 -> 1.4.95
bf8a421 
Update brave from 1.3.118 to 1.4.95

(cherry picked from commit fa166b7)
Reason: Browser should be kept up-to-date for security reasons.
@JeffLabonte JeffLabonte force-pushed the release/20.03-brave_1.3.118_to_1.4.95 branch from 50d2d4a to bf8a421 Compare March 4, 2020 01:16
@worldofpeace worldofpeace changed the title nixos: Update brave from 1.3.118 to 1.4.95 [20.03] brave: 1.3.118 -> 1.4.95 Mar 4, 2020
worldofpeace
worldofpeace approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works.

@worldofpeace worldofpeace merged commit 87cc49a into NixOS:release-20.03 Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@rht rht Awaiting requested review from rht

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeffLabonte @worldofpeace