Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lutris: Add metadata from lutris-unwrapped also to lutris #81107

Closed
wants to merge 1 commit into from
Closed

lutris: Add metadata from lutris-unwrapped also to lutris #81107

wants to merge 1 commit into from

Conversation

clkamp
Copy link
Contributor

@clkamp clkamp commented Feb 26, 2020

...and lutris-free, so that they can be found by repology.

Motivation for this change

Closes #72921

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@clkamp
lutris: Add metadata from lutris-unwrapped also to lutris
b737ddb 
...and lutris-free, so that they can be found by repology.

Closes NixOS#72921
@ofborg ofborg bot requested a review from Chiiruno February 26, 2020 11:34
@clkamp
Copy link
Contributor Author

clkamp commented Feb 26, 2020

@GrahamcOfBorg build lutris-free

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/126

veprbl
veprbl reviewed Mar 20, 2020
View reviewed changes
pkgs/applications/misc/lutris/chrootenv.nix
@@ -113,5 +113,13 @@ in buildFHSUserEnv {
mkdir -p $out/share
ln -sf ${lutris-unwrapped}/share/applications $out/share
ln -sf ${lutris-unwrapped}/share/icons $out/share
ln -s $out/bin/lutris-${lutris-unwrapped.version} $out/bin/lutris
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a metadata change. Please move it to separate commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this

davidak
davidak requested changes Jun 1, 2020
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except the one line

pkgs/applications/misc/lutris/chrootenv.nix
@@ -113,5 +113,13 @@ in buildFHSUserEnv {
mkdir -p $out/share
ln -sf ${lutris-unwrapped}/share/applications $out/share
ln -sf ${lutris-unwrapped}/share/icons $out/share
ln -s $out/bin/lutris-${lutris-unwrapped.version} $out/bin/lutris
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this

baracoder
baracoder reviewed Aug 21, 2020
View reviewed changes
pkgs/applications/misc/lutris/chrootenv.nix
'';

meta = with lutris-unwrapped.meta; {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this just meta = lutris-unwrapped.meta; ?

@baracoder
Copy link
Contributor

ping
@clkamp to move this PR forward, can you take a look look at the requested changes and update the PR?

@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@Atemu Atemu mentioned this pull request Sep 22, 2021
Merged
12 tasks
Artturin pushed a commit that referenced this pull request Oct 15, 2021
@Atemu
lutris: propagate important meta attrs to FHSEnv wrapper
1fc860b 
Closes #81107
github-actions bot pushed a commit that referenced this pull request Oct 23, 2021
@Atemu @github-actions
lutris: propagate important meta attrs to FHSEnv wrapper
3c07a4f 
Closes #81107

(cherry picked from commit 1fc860b)
jordanisaacs pushed a commit to jordanisaacs/nixpkgs that referenced this pull request Oct 26, 2021
@Atemu @jordanisaacs
lutris: propagate important meta attrs to FHSEnv wrapper
cd93ce6 
Closes NixOS#81107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baracoder baracoder baracoder left review comments

@veprbl veprbl veprbl left review comments

@davidak davidak davidak requested changes

@Chiiruno Chiiruno Awaiting requested review from Chiiruno

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 9.needs: reporter feedback 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lutris: clean up metadata
6 participants
@clkamp @nixos-discourse @baracoder @davidak @veprbl @ryantm