Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 158cd27ae7a1
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 1de12214768d
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Feb 23, 2020

  1. nixos/acme: move the crt to fullchain.pem

    lego already bundles the chain with the certificate,[1] so the current
    code, designed for simp_le, was resulting in duplicate certificate
    chains, manifesting as "Chain issues: Incorrect order, Extra certs" on
    the Qualys SSL Server Test.
    
    cert.pem stays around as a symlink for backwards compatibility.
    
    [1] https://github.com/go-acme/lego/blob/5cdc0002e9abb2463fffc962dadc3479f72d7486/acme/api/certificate.go#L40-L44
    
    (cherry picked from commit 8ecbd97)
    emilazy committed Feb 23, 2020
    Copy the full SHA
    f5749a7 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2020

  1. Merge pull request #80862 from emilazy/acme-fullchain-20.03

    [20.03] nixos/acme: move the crt to fullchain.pem
    infinisil committed Feb 26, 2020
    Copy the full SHA
    1de1221 View commit details
    Browse the repository at this point in the history