New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go_1_14: init at 1.14 and switch to it #81071
Conversation
@GrahamcOfBorg build yq-go hugo restic terraform |
@GrahamcOfBorg build yq-go hugo restic terraform jx pet |
Got this when applying the patch, which may or may not be relevant:
|
@rvolosatovs I think it's okay. The patch applies successfully anyway. There are whitespaces in the patch because of the way how it's formatted (it has two chars at the beginning of the line "booked" for +- chars and on the lines where only addition happens you'll have + and whitespace) in combination with tabs usage in Go. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nixos-20-03-feature-freeze/5655/37 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome :) - It looks like nothing is getting overridden to go1.13 - do we need to still keep it around?
Also you motivated me to go check some of the go 1.12 overrides, so I opened #81159 to get rid of some of them. |
@c00w I've been thinking about going through 1.12 first to get rid of it and then consider getting rid of 1.13 as well. Generally, it probably makes sense to keep the last two versions of the compiler, but not sure about it. |
In general we should only keep go versions around that are also supported upstream with security updates. |
Per https://golang.org/doc/devel/release.html#policy - only the last 2 releases are supported (i.e. go 1.12 is no longer supported). I think before go1.13 landed we only had 1 version of go. go 1.12 was kept around because a number of packages didn't work with go 1.13. I don't think there is a lot of benefit to keeping a go version around other than the latest one if we don't need it to build a given package. |
@Frostman if there are fairly unmaintained it might also an option to remove them from nixpkgs depending on the package. |
Motivation for this change
https://golang.org/doc/go1.14
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)5 package failed to build - same set as in minor go version bump #80506 (related to git2go or not related to go)
act blsd gitAndTools.grv gitaly python38Packages.aria2p
736 package built
This change is