Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.draw-on-your-screen: init at 6 #81073

Merged
merged 1 commit into from Mar 22, 2020
Merged

gnomeExtensions.draw-on-your-screen: init at 6 #81073

merged 1 commit into from Mar 22, 2020

Conversation

ericdallo
Copy link
Member

Motivation for this change

Add gnome extension draw-on-your-screen.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/129

@ericdallo ericdallo force-pushed the gnome-extensions-drawn-on-your-screen branch from fdcc2b2 to f83398f Compare March 15, 2020 20:44
@ericdallo
Copy link
Member Author

Done @jtojnar! Thanks!

@veprbl veprbl changed the title gnomeExtensions.draw-on-your-screen: init at 5 gnomeExtensions.draw-on-your-screen: init at 6 Mar 20, 2020
@ericdallo ericdallo force-pushed the gnome-extensions-drawn-on-your-screen branch from f83398f to 3064aa7 Compare March 21, 2020 00:50
@veprbl
Copy link
Member

veprbl commented Mar 21, 2020

@GrahamcOfBorg build gnomeExtensions.draw-on-your-screen

veprbl
veprbl approved these changes Mar 21, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl veprbl merged commit 7b389de into NixOS:master Mar 22, 2020
@ericdallo ericdallo deleted the gnome-extensions-drawn-on-your-screen branch March 22, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@veprbl veprbl veprbl approved these changes

@hedning hedning Awaiting requested review from hedning

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ericdallo @nixos-discourse @veprbl @jtojnar