icon-lang: 9.5.1 -> unstable-2020-02-05 #81038
Conversation
KoviRobi
changed the title
|
LGTM thanks! |
|
I think patching the build instead of using unstable release may make more sense: #80714 |
|
Possibly, but version 9.5.1 is seven years old, which is why I decided to do so. Perhaps if you want to stick with releases, EDIT: Tested, replied in more detail on #80714 |
KoviRobi
changed the title
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
Please resolve the merge conflict(s). |
Latest release (https://github.com/gtownsend/icon/releases/tag/ok2018j) doesn't seem like a properly versioned release. Latest properly versioned release (https://github.com/gtownsend/icon/releases/tag/rel951) is from 2013. So I have decided to use the unstable release, which works.
KoviRobi
force-pushed
the
zhf-20.03-update-icon-lang
branch
from
26fffc2
to
99addb8
Compare
|
Result of 2 packages built:
|
Latest release (https://github.com/gtownsend/icon/releases/tag/ok2018j)
doesn't seem like a properly versioned release. Latest properly
versioned release
(https://github.com/gtownsend/icon/releases/tag/rel951) is from 2013. So
I have decided to use the unstable release, which works.
Motivation for this change
(This was ZHF: #80379 but a different PR resolved that)
Things done
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS linux)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"Not sure I have done this correctly, it doesn't seem to build e.g.
noweb, which I knownowebdepends on this (and is currently broken). Will try to makenowebwork too, agrepdoesn't indicate any other dependencies.Tested execution of all binary files (usually in
./result/bin/)Not tested all binary files, but tested noweb (see PR noweb: fix installation of manpages, use placeholders #81042, which depends on this)
Determined the impact on package closure size (by running
nix path-info -Sbefore and after)Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.