Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmigemo: init at 1.3e #81132

Merged
merged 2 commits into from Sep 10, 2020
Merged

cmigemo: init at 1.3e #81132

merged 2 commits into from Sep 10, 2020
+66 −0

Conversation

cohei
Copy link
Contributor

@cohei cohei commented Feb 26, 2020 •
edited

cmigemo is a tool that supports Japanese incremental search with Romaji.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cohei
Copy link
Contributor Author

cohei commented Feb 26, 2020

Maintainers not yet set. Who should I assign?

@cohei cohei marked this pull request as ready for review February 29, 2020 01:04
@doronbehar
Copy link
Contributor

Maintainers not yet set. Who should I assign?

Yourself.

@doronbehar
Copy link
Contributor

I don't know why but you should strive to fix the ci errors. Before pushing you can make sure they won't fail if you'll follow:

https://github.com/NixOS/ofborg#how-does-ofborg-call-nix-instantiate

@cohei
Copy link
Contributor Author

cohei commented Jul 31, 2020 •
edited

While building cmigemo, curl downloads a dictionary for cmigemo to convert words. But only fetch* nix functions can download something in sandbox. I think that is why ci failed.

I'm trying to fix it.

@cohei
Copy link
Contributor Author

cohei commented Aug 1, 2020 •
edited

In installPhase, install command fails only in sandbox. Why...

/usr/bin/install -c -m 644 dict/migemo-dict /nix/store/pf570qgjzhswcja6nvp040bav41bxmmg-cmigemo-1.3e/share/migemo/cp932
/nix/store/lpqq5knklpr4v7s7nf2lzx6jx6615q6y-bash-4.4-p23/bin/bash: /usr/bin/install: Operation not permitted

@gebner
Copy link
Member

gebner commented Aug 22, 2020

@cohei That's because we don't have /usr/bin/install on nixos. You might able to override the makefile using makeFlags = [ "INSTALL=install" ]. Otherwise you could use the substituteInPlace function to replace /usr/bin/install by install in the right files.

@cohei
Copy link
Contributor Author

cohei commented Aug 23, 2020

@gebner Thank you! I'll try.

@cohei
Copy link
Contributor Author

cohei commented Sep 9, 2020

@gebner It works. Thanks again!

gebner
gebner approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@gebner gebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise.

maintainers/maintainer-list.nix
@@ -1641,6 +1641,12 @@
githubId = 5561189;
name = "Cody Opel";
};
cohei = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the maintainer list addition into a separate commit (maintainers: add cohei).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@cohei
maintainers: add cohei
8a6f804
@cohei
cmigemo: init at 1.3e
b063ae1 
cmigemo is a tool that supports Japanese incremental search with Romaji.
@gebner gebner merged commit 1ccafcb into NixOS:master Sep 10, 2020
@cohei cohei deleted the init-cmigemo branch September 10, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner gebner approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cohei @doronbehar @gebner