Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cadence: fix dbus,libjack and missing dependancies #81098

Merged
merged 2 commits into from Mar 14, 2020

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented Feb 26, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This should fix #55574

@bignaux
Copy link
Contributor Author

bignaux commented Feb 26, 2020

@GrahamcOfBorg build cadence
@worldofpeace ping

Comment on lines -68 to +90
makeWrapper ${python3Packages.python.interpreter} ${script} \
--set PYTHONPATH "$PYTHONPATH:${outRef}/share/cadence" \
''${qtWrapperArgs[@]} \
--add-flags "-O ${source}"
makeQtWrapper ${source} ${script} \
--prefix PATH : "${lib.makeBinPath [
jack_capture # cadence-render
pulseaudioFull # cadence, cadence-session-start
]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this remove all the important PYTHONPATH changes to the wrapper?
Can you also indent properly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python3 seems to be better than python3Packages, then no need for propagatedBuildInputs and such things in the wrapper. I test heavily to catch others bugs. BTW, i've another thing i'd fix, and i've no idea how to do that properly, I need /nix/store/v433wawv8hl23kb2c2qk0lgg86sainc1-a2jmidid-8/share/dbus-1/services/org.gna.home.a2jmidid.service to be activated .
we can complete with a :

postInstall = ''
# D-Bus activation
install -Dm755 ${a2jmidid}/share/dbus-1/services/org.gna.home.a2jmidid.service -t $out/share/dbus-1/services/
''
but user need to reboot for the service to be activated by dbus. There is a lot of issue with dbus activation #17943 for example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worldofpeace The wrapped python interpreter contains hard-coded references to the correct paths. There is no need to set PYTHONPATH when using withPackages.

@magnetophon
Copy link
Member

magnetophon commented Feb 28, 2020

This indeed fixes #55574.
Thanks, @bignaux !

@zarybnicky
Copy link

I can confirm that cadence works. Trying out claudia, packaged here as well, I'm encountering

dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NameHasNoOwner: Could not get owner of name 'org.ladish': no such name

I found one mention of the problem in mageia - https://bugs.mageia.org/show_bug.cgi?id=17867 - where they've found out that packaging ladish is necessary for claudia to run.

@bignaux
Copy link
Contributor Author

bignaux commented Mar 5, 2020

Yes i wrote a comment on that . anyway, package the dead ladish is not impossible but i wont . https://github.com/NixOS/nixpkgs/pull/81098/files#diff-5e87607c20c10470e7a0346a3be0f6e2R16
Right now, i can't use my audio device since broken ffado ...

@zarybnicky
Copy link

Aha, I missed that comment, sorry. In any case, a working cadence is already a nice step forward for NixOS Audio :)

@bignaux
Copy link
Contributor Author

bignaux commented Mar 5, 2020

only if it is merged. I spend days to fix things in the repo, and get sometime frustrate to see some typo or no reaction. A good orga is measured by the ability to delegate.

@adisbladis adisbladis merged commit 77396a8 into NixOS:master Mar 14, 2020
@bignaux bignaux deleted the cadence branch March 14, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cadence doesn't see jack
5 participants