Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smartmontools: 7.0 -> 7.1 and devicedb updated to latest #81099

Merged
merged 2 commits into from Feb 29, 2020
Merged

smartmontools: 7.0 -> 7.1 and devicedb updated to latest #81099

merged 2 commits into from Feb 29, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Feb 26, 2020 •
edited

Motivation for this change

https://www.smartmontools.org/browser/tags/RELEASE_7_1/smartmontools/NEWS

Currently, we have 1+ year old devicedb.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

Frostman
Frostman commented Feb 26, 2020
View reviewed changes
pkgs/tools/system/smartmontools/default.nix
dbrev = "4883";
drivedbBranch = "RELEASE_${builtins.replaceStrings ["."] ["_"] version}_DRIVEDB";
dbrev = "5033";
drivedbBranch = "RELEASE_7_0_DRIVEDB";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: there is no dedicated branch for 7.1. The 7.0 branch is supposed to be used for both 7.0 and 7.1.

@ofborg ofborg bot requested a review from peti February 26, 2020 07:28
@Frostman
Copy link
Member Author

cc @dtzWill @xeji @andir

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixos-20-03-feature-freeze/5655/37

@andir
Copy link
Member

andir commented Feb 29, 2020

@worldofpeace any objections against including this in 20.03? It seems like a good addition.

@andir andir merged commit c8f7c0a into NixOS:master Feb 29, 2020
@Frostman Frostman deleted the smartmontools-7.1 branch March 1, 2020 08:17
@Frostman
Copy link
Member Author

Frostman commented Mar 1, 2020

I've backported and tested it #81423

@dtzWill
Copy link
Member

dtzWill commented Mar 3, 2020

Belated 👍, thanks!

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 3, 2020
@andir @dtzWill
Merge pull request NixOS#81099 from Frostman/smartmontools-7.1
f26a7c6 
smartmontools: 7.0 -> 7.1 and devicedb updated to latest
(cherry picked from commit c8f7c0a)
@Frostman Frostman mentioned this pull request Jun 1, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Frostman @nixos-discourse @andir @dtzWill