Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab v12.8 #81057

Closed
wants to merge 4 commits into from
Closed

Gitlab v12.8 #81057

wants to merge 4 commits into from

Conversation

jslight90
Copy link
Contributor

@jslight90 jslight90 commented Feb 25, 2020

Motivation for this change

Update GitLab to latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jslight90 jslight90 changed the title WIP: Gitlab v12.8 Gitlab v12.8 Feb 26, 2020
, libiconv, Security
}:

stdenv.mkDerivation rec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you just do a libgit2_0_27 = libgit.overrideAtts… inside a let expression inside gitaly/default.nix, that simply overwrites src? That way it's clear where this is used, and we avoid duplicating this whole file.

@talyz talyz mentioned this pull request Mar 2, 2020
10 tasks
@ghost
Copy link

ghost commented Mar 3, 2020

Replaced by #81556, thanks for the initial work!

@ghost ghost closed this Mar 3, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants