Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] mariadb-connector-c: add mysqlclient.pc pkgconfig symlink #81045

Merged
merged 1 commit into from Mar 28, 2020
Merged

[20.03] mariadb-connector-c: add mysqlclient.pc pkgconfig symlink #81045

merged 1 commit into from Mar 28, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Feb 25, 2020

Motivation for this change

Backport #80756

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Mic92

@ofborg ofborg bot requested a review from globin February 25, 2020 19:47
@B4dM4n
Copy link
Contributor Author

B4dM4n commented Feb 29, 2020

Ping @NixOS/nixos-release-managers

@Mindavi
Copy link
Contributor

Mindavi commented Mar 16, 2020 •
edited

Can confirm this works to fix the bitwarden_rs-mysql build.
ZHF: #80379

I've checked that the binary at least runs.

@globin globin merged commit 8ad6e4e into NixOS:staging-20.03 Mar 28, 2020
@B4dM4n B4dM4n deleted the backport-mariadb-pkgconfig-link branch March 28, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@B4dM4n @Mindavi @globin