Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc: add 8.8.3 (copied from 8.8.2) #80975

Merged
merged 1 commit into from Feb 25, 2020
Merged

ghc: add 8.8.3 (copied from 8.8.2) #80975

merged 1 commit into from Feb 25, 2020

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Feb 24, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ggreif
Copy link
Contributor Author

ggreif commented Feb 24, 2020

@GrahamcOfBorg build haskell.compiler.ghc883

1 similar comment
@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskell.compiler.ghc883

cdepillabout
cdepillabout approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggreif LGTM.

Also pinging @peti, @Ericson2314, and @matthewbauer, since I think they do work on the GHC derivations.

@ggreif
Copy link
Contributor Author

ggreif commented Feb 25, 2020 •
edited

Remains to be fixed:

@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskell.compiler.ghc883

@ggreif The CI failure is probably from some other problem in haskell-updates. It is likely this PR didn't cause it, so you can probably ignore it.

@peti peti merged commit 1c124e2 into NixOS:haskell-updates Feb 25, 2020
@ggreif ggreif deleted the haskell-updates branch February 25, 2020 18:58
@ggreif ggreif mentioned this pull request Feb 27, 2020
Merged
10 tasks
@Mateiadrielrafael Mateiadrielrafael mentioned this pull request Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ggreif @cdepillabout @peti