Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZHF] pythonPackages.reproject: fix tests #81037

Merged
merged 1 commit into from Feb 26, 2020
Merged

[ZHF] pythonPackages.reproject: fix tests #81037

merged 1 commit into from Feb 26, 2020

Conversation

smaret
Copy link
Member

@smaret smaret commented Feb 25, 2020

Motivation for this change

Fix tests.

ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl changed the title python: reproject: fix tests [ZHF] pythonPackages.reproject: fix tests Feb 25, 2020
@veprbl veprbl added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Feb 25, 2020
@smaret
Copy link
Member Author

smaret commented Feb 25, 2020

Upstream fix: astropy/reproject#218

@smaret @jonringer
pythonPackages.reproject: fix tests
dee42c2 
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build python3Packages.reproject

jonringer
jonringer approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[6 built, 66 copied (573.9 MiB), 123.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81037
4 package built:
python37Packages.aplpy python37Packages.reproject python38Packages.aplpy python38Packages.reproject

@jonringer jonringer merged commit a0f50fe into NixOS:master Feb 26, 2020
@smaret smaret deleted the reproject-fix-tests branch February 26, 2020 09:51
@smaret
Copy link
Member Author

smaret commented Feb 26, 2020

Can someone from @NixOS/nixos-release-managers backport this to the 20.3-release branch please?

@worldofpeace
Copy link
Contributor

@smaret See step 5. #80379 (comment).
You can open a PR for them.

@smaret smaret mentioned this pull request Feb 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: wait-for-upstream Waiting for upstream fix (or their other action). 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smaret @worldofpeace @veprbl @jonringer