Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] pythonPackages.sfepy: 2019.2 -> 2019.4 #81043

Merged
merged 1 commit into from Feb 27, 2020
Merged

[20.03] pythonPackages.sfepy: 2019.2 -> 2019.4 #81043

merged 1 commit into from Feb 27, 2020

Conversation

wd15
Copy link
Contributor

@wd15 wd15 commented Feb 25, 2020 •
edited

Motivation for this change

Fix broken Hydra tests for release 20.03

  • Bump the version number to fix incompatibility with Numpy 1.18.1
  • Remove broken test to fix incompatibility with Numpy 1.18.1

For ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wd15
pythonPackages.sfepy: 2019.2 -> 2019.4
f6fa019 
 - Bump the version number to fix incompatibility with Numpy 1.18.1
 - Remove broken test to fix incompatibility with Numpy 1.18.1
@wd15 wd15 changed the title pythonPackages.sfepy: 2019.2 -> 2019.4 [20.03] pythonPackages.sfepy: 2019.2 -> 2019.4 Feb 25, 2020
@wd15
Copy link
Contributor Author

wd15 commented Feb 25, 2020

Result of nix-review pr 81043 1

3 package were built:
  • python27Packages.sfepy
  • python37Packages.sfepy
  • python38Packages.sfepy

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 27, 2020

@GrahamcOfBorg build python27Packages.sfepy python37Packages.sfepy python38Packages.sfepy

@rnhmjoj rnhmjoj merged commit a2bb258 into NixOS:release-20.03 Feb 27, 2020
@rnhmjoj rnhmjoj mentioned this pull request Feb 28, 2020
Closed
10 tasks
@wd15 wd15 deleted the sfepy-2019.4 branch February 28, 2020 20:57
@wd15 wd15 mentioned this pull request Feb 28, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wd15 @rnhmjoj