buildRustPackage: do validateCargoDeps after patchPhase #81065
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is an attempt to fix some issues that got mentioned in #79975 with the new
fetchCargoTarball
fetcher.The primary issue seems to be that
validateCargoDeps
is checked duringpostUnpack
whencargoPatches
is not applied yet and builds that have to modifyCargo.lock
will therefore fail the check.Things done
I tested the
cargo
,rls
andclippy
builds which use thecargoVendorDir
flag,rink
andgit-dit
(update wip) which usecargoPatches
to create theCargo.lock
and other crates likecargo-web
orparinfer-rust
which use the upstreamCargo.lock
.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)