Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the handling of unloaded parts to prevent vessels exploding on "set orbit" #2483

Merged
merged 8 commits into from
Feb 26, 2020

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Feb 26, 2020

No description provided.

PartId const part_id_;
std::string const name_;
bool const loaded_;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename Part::loaded_, Part::loaded, Plugin::PartIsLoaded, and principia__PartIsLoaded (and the corresponding message) to truthful (since all properties but the name and ID, including properties stored in the pile up, are a lie when that property is false); this is a persistent property of the C++-side part which is distinct from what we call "loaded".

"Loaded" elsewhere (including in Insert(L|Unl)oadedPart) should probably be renamed to "Unpacked" for consistency with the C# terminology, where there is also a "loaded" which means a different thing, but that's a job for another pull request.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Feb 26, 2020
@pleroy pleroy merged commit bb5029f into mockingbirdnest:frobenioid Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants