Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitkraken: 6.5.1 -> 6.5.3 #81083

Merged
merged 1 commit into from Feb 29, 2020
Merged

gitkraken: 6.5.1 -> 6.5.3 #81083

merged 1 commit into from Feb 29, 2020

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Feb 26, 2020

Motivation for this change

https://support.gitkraken.com/release-notes/current/#version-653

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evanjs
Copy link
Member Author

evanjs commented Feb 28, 2020

cc @megheaiulian @worldofpeace because I can't add reviewers for some reason :D

@worldofpeace worldofpeace merged commit 180e5f4 into NixOS:master Feb 29, 2020
@worldofpeace
Copy link
Contributor

Now the great question, is a backport needed/possible?

@evanjs
Copy link
Member Author

evanjs commented Feb 29, 2020

Now the great question, is a backport needed/possible?

@worldofpeace

6.5.3 seems to merely include a fix for a Windows Defender false positive, though there were some bug fixes for all platforms in 6.5.2.

Haven't done backports here before, but is there really anything significant required for them?
This is a leaf package so I can't see it causing too many issues.

@worldofpeace
Copy link
Contributor

@evanjs See https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes. It's prominent to use cherry-pick -x on the release branch (20.03).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evanjs @worldofpeace