Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: add missing nrt gui sprites #34

Merged
merged 1 commit into from Feb 26, 2020

Conversation

andythenorth
Copy link
Contributor

The convert tools using the sprites from #9 aren't looking right.

The existing rail convert icon is much higher fidelity, but I can't find it yet to figure why (oof).

@andythenorth
Copy link
Contributor Author

  • the first 2 icons in tram building toolbar are showing road
  • the rail convert toolbar is included in sprites/png/gui/gui2x.png, but the equivalent road/tram convert icons are not provided at 2x yet, this looks inconsistent

@andythenorth andythenorth force-pushed the 9-missing-nrt-gui-sprites branch 4 times, most recently from 7ef5f64 to e18a595 Compare February 26, 2020 21:39
@andythenorth
Copy link
Contributor Author

andythenorth commented Feb 26, 2020

Everything done as per list in #9 (comment)

Ready for review thx

@@ -319,3 +319,11 @@ replacenew ottd_gui175(OTTD_GUI, "", 175) {
[ 44, 0, 20, 20, 0, 0, "sprites/png/gui/group_liveries.png"] // boat group livery icon
[ 66, 0, 20, 20, 0, 0, "sprites/png/gui/group_liveries.png"] // aircraft group livery icon
}
replacenew ottd_gui179(OTTD_GUI, "", 179) { [ 0, 0, 20, 20, 0, 0, "sprites/png/extra/extra-gui-build-tram.png"] } // global toolbar build tram
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could split these over a few more lines, like the above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follows apparent house style per

alternative_sprites (ottd_gui55, ZOOM_LEVEL_IN_2X, BIT_DEPTH_8BPP) { tmpl_gui2x_file_toolbar(242, 456, "sprites/png/gui/gui2x.png") }

I don't like it, but eh

Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯\_(ツ)_/¯

@andythenorth andythenorth merged commit e4e14d1 into OpenTTD:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants