nixos/tests/opensmtpd: bump test (&build) timeout to 30m from 30s #81060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure how this ever passed on hydra but 30s is barely enough to pass the configure phase of opensmtpd. It is likely the package was built as part of another jobset. Whenever it is built as part of the test execution the timeout propagates and 30s is clearly not enough for that.
|
@GrahamcOfBorg test opensmtpd |
|
Not sure what you mean by “the timeout propagates,” but if memory serves me right, I had just grepped for another So I'm not setting an r+ because I'm not sure I get the issue, but don't have any reason to reject this change either :) |
|
On 03:59 26.02.20, Léo Gaspard wrote:
Not sure what you mean by “the timeout propagates,” but if memory
serves me right, I had just grepped for another `meta.timeout` setting
somewhere else, built that other thing, and then used proportionality
to set the `meta.timeout` option for the opensmtpd test.
In the NixOS release channel the opensmtpd package might only be built
because of the test depending on it. In that case all of the builds
required by the test will inherit the timeout set on the test. It might
work in some cases because a nixpkgs job might have built the binary
beforehand and the test isn't release critical.
NixOS VM tests rarely ever finish in 30s on hydra. Those build machines
might be very busy and execution usually takes multiple minutes. The 30s
limit is therefore not really appropirate of those either.
So I'm not setting an r+ because I'm not sure I get the issue, but
don't have any reason to reject this change either :)
Let me know if the above explanation did help.
|
|
Oh wow, I didn't even imagine Anyway, thank you for having handled this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I am not sure how this ever passed on hydra but 30s is barely enough to
pass the configure phase of opensmtpd. It is likely the package was
built as part of another jobset. Whenever it is built as part of the
test execution the timeout propagates and 30s is clearly not enough for
that.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)