Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.hibernate-status: init at 1.5 #81062

Closed
wants to merge 1 commit into from
Closed

gnomeExtensions.hibernate-status: init at 1.5 #81062

wants to merge 1 commit into from

Conversation

ericdallo
Copy link
Member

Motivation for this change

Add gnome extension hibernate-status button

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/129

@jtojnar
Copy link
Contributor

jtojnar commented Mar 15, 2020

Looks like this will not be maintained any more: arelange/gnome-shell-extension-hibernate-status#44 (comment)

@ericdallo
Copy link
Member Author

Yeah, it looks like gnome 3.36 improve this behavior too, so should we close this PR?

@jtojnar
Copy link
Contributor

jtojnar commented Mar 15, 2020

Yeah, that would probably be the best course of action. Otherwise we would just have to mark it as broken.

@ericdallo
Copy link
Member Author

Right, thank you @jtojnar!

@ericdallo ericdallo closed this Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericdallo @nixos-discourse @jtojnar