Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dat: init at 13.13.1 #78356

Merged
merged 1 commit into from Jan 27, 2020
Merged

dat: init at 13.13.1 #78356

merged 1 commit into from Jan 27, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jan 23, 2020 •
edited

Motivation for this change

dat is a tool for peer-to-peer sharing & live synchronization of files similar to IPFS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member Author

prusnak commented Jan 23, 2020

The preFixup phase is taken from the now-cli package. It might be worth refactoring into a common function used by both packages, but I don't know how exactly to do this. Suggestions welcome!

@mmahut
Copy link
Member

mmahut commented Jan 27, 2020

It would be cool add support to fix the offsets directly to the patchelf project. It did glance at open issues, but did not see it there yet.

@mmahut mmahut merged commit ae2986e into NixOS:master Jan 27, 2020
@dtzWill
Copy link
Member

dtzWill commented Jan 27, 2020

Hmm, this looks like a duplicate of nodePackages.dat (which perhaps could be made more visible).

Is there a reason to prefer this, or should this be dropped in favor of nodePackages.dat?

@mmahut
Copy link
Member

mmahut commented Jan 27, 2020

@dtzWill is right. Should we at least alias it? I assumed nodePackages were mostly nodejs libraries, not usable binaries.

@mmahut mmahut mentioned this pull request Jan 30, 2020
Merged
10 tasks
@prusnak prusnak deleted the dat branch November 10, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @mmahut @dtzWill