Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains.*: 2019.3.x -> 2019.3.x+1 #78357

Merged
merged 9 commits into from
Jan 24, 2020
Merged

jetbrains.*: 2019.3.x -> 2019.3.x+1 #78357

merged 9 commits into from
Jan 24, 2020
+21 −21

Conversation

liff
Copy link
Contributor

@liff liff commented Jan 23, 2020

Motivation for this change

Update JetBrains products to latest versions in 2019.3 series. Also includes update of the JetBrains JDK to match the version that is bundled with the default download of the products: 520.30.

This PR has one commit per package. Let me know it squashing it would be preferable.

Release notes:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@liff liff requested a review from edwtjo as a code owner January 23, 2020 12:37
jonringer
jonringer approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
was able to open pycharm fine

[33 built, 1 copied (349.3 MiB), 347.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78357
12 package built:
jetbrains.clion jetbrains.datagrip jetbrains.goland jetbrains.idea-community jetbrains.idea-ultimate jetbrains.jdk jetbrains.phpstorm jetbrains.pycharm-community jetbrains.pycharm-professional jetbrains.rider jetbrains.ruby-mine jetbrains.webstorm

@jonringer jonringer merged commit 741faf7 into NixOS:master Jan 24, 2020
@liff liff deleted the jetbrains/v2019.3.3 branch November 14, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@edwtjo edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liff @jonringer