Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csr.bus.Element: fix src_loc_at. #5

Merged
merged 1 commit into from Jan 23, 2020
Merged

csr.bus.Element: fix src_loc_at. #5

merged 1 commit into from Jan 23, 2020

Conversation

jfng
Copy link
Contributor

@jfng jfng commented Jan 23, 2020

Use case:

from nmigen_soc import csr

def wrapper(width, access):
    return csr.Element(width, access, src_loc_at=1)
foo = wrapper(8, "r")

print(foo.name)
# before this commit: None
# after: foo

@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #5   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         415    415           
  Branches       91     91           
=====================================
  Hits          415    415
Impacted Files Coverage Δ
nmigen_soc/csr/bus.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3195de9...efab806. Read the comment docs.

@whitequark
Copy link
Contributor

Thanks!

@whitequark whitequark merged commit 3737595 into m-labs:master Jan 23, 2020
@jfng jfng deleted the fix-csr-src_loc branch January 23, 2020 12:29
@nmigen-issue-migration nmigen-issue-migration mentioned this pull request Jan 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfng @whitequark