Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/vault: add ExecReload entry #78427

Merged
merged 1 commit into from
Jan 24, 2020
Merged

nixos/vault: add ExecReload entry #78427

merged 1 commit into from
Jan 24, 2020
+1 −0

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

We want to make vault reload config and SSL keys without resealing. This is possible using a SIGHUP. Let's add a systemd config so that systemctl reload works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@yorickvP
nixos/vault: add ExecReload entry

Verified

This commit was signed with the committer’s verified signature.
markuskowa Markus Kowalewski
GPG key ID: D865C8A91D7025EB
Verified
Learn about vigilant mode
15e98e7
@yorickvP yorickvP requested review from volth and LnL7 January 24, 2020 18:03
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 24, 2020
@nlewo nlewo merged commit adcbe7b into NixOS:master Jan 24, 2020
@yorickvP yorickvP deleted the yorickvp/vault-reload branch January 24, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yorickvP @nlewo