Skip to content

nixos/prometheus/nginx-exporter: Add nginx dependency #78364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

nixos/prometheus/nginx-exporter: Add nginx dependency #78364

wants to merge 1 commit into from
+3 −1

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

If the nginx exporter starts before nginx, it fails. Add a service dependency to fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@yorickvP
nixos/prometheus/nginx-exporter: Add nginx dependency

Verified

This commit was signed with the committer’s verified signature.
sikmir Nikolay Korotkiy
GPG key ID: D1DE6D7F693663A5
Verified
Learn about vigilant mode
db29d6e
@yorickvP yorickvP requested a review from WilliButz January 23, 2020 13:23
mkaito
mkaito approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@mkaito mkaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been on our production machines for a little while already.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 23, 2020
@WilliButz
Copy link
Member

Since adc5ae7 the dependency is already added if the nginx module is enabled on the same host (see exporters.nix).

Is there an issue with this, that led to your proposed change?

@yorickvP
Copy link
Contributor Author

Ah, okay, that will work :)

@yorickvP yorickvP closed this Jan 23, 2020
@yorickvP yorickvP deleted the mkaito/nginx-exporter branch January 23, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaito mkaito

@WilliButz WilliButz

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yorickvP @WilliButz @mkaito