nix-gitignore: update to v3.0.2 (mostly compatible changes) #78371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennofs
reviewed
Apr 27, 2020
Comment on lines
+150
to
+153
| withGitIgnoredFilesAndDirs = patterns: root: | ||
| lib.toList patterns ++ [(root + "/.gitignore") (".git")]; | ||
|
|
||
| withRecursiveGitignoreFile = patterns: root: | ||
| withRecursiveGitIgnoredFilesAndDirs = patterns: root: |
There was a problem hiding this comment.
Are these renames necessary? To me, it feels like that would break compatibility with existing code for no good reason.
But since you already renamed them in the repo, maybe it would be good to rename for consistency. Perhaps we could at least add an alias for some time, with a warning (using lib.warn) to make transitioning easier?
blitz
approved these changes
Jul 6, 2020
|
hi there. what's the status here, what can we do to get this through? |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from the main repo, changes have been published for a while now, with nothing major having been done. Everything seems to be working.