chromium: increase parallelism on aarch64 #78347
Conversation
thefloweringash
force-pushed
the
chromium-aarch64-parallelism
branch
from
001e34c
to
9f270b3
Compare
|
If we were going for minimalistic chromium changes, perhaps I'd do -($NIX_BUILD_CORES+1) / 2
+ $NIX_BUILD_CORES/2 + 1(regardless of platform). This function seems to have a bit more suitable properties. |
|
@vcunat is it because ghc takes so much time (on aarch64) that it's only built on the release channel, and not the unstable channel? I've been trying to use ghc on aarch64 lately and noticed that I have to compile all ghc-related packages myself. |
| # the 2 day limit. | ||
| "-j$NIX_BUILD_CORES -l$NIX_BUILD_CORES" | ||
| else | ||
| # Build paralelism: on Hydra the build was frequently running into memory |
There was a problem hiding this comment.
Unrelated nit: while we're here it might be worth fixing the paralelism typo to parallelism
|
@L-as: no. Taking lots of time does often cause failures and that's easier to handle by manual restarts on stable branch due to having much fewer ghc rebuilds, but the difference is in ghc version which blows size over our limit. See this ticket: #66277 Even on unstable/master you can still use binaries for lower version of ghc: https://hydra.nixos.org/job/nixpkgs/trunk/haskell.compiler.ghc865.aarch64-linux (but basically no haskellPackages with it are in cache, I think, due to not being default version anymore) |
|
This issue was to solve a particular problem with the aarch64 build timing out, which is no longer a problem so I will close this. There's a new issue for discussing this logic in #100486. |
Motivation for this change
The chromium build on hydra for aarch64 is regularly timing out after two days. With the current configuration of
nix.buildCores = 2and the chromium parallelism limit halving that, it's being run on a single core of the 32-core builder.Opening as a draft for discussion, since reconfiguring the builders to use more than 2 cores per build might be justifiable if we assume most software will make good use of them.
cc @grahamc
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)