Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iputils: Increase the priority to avoid collisions with inetutils #78408

Merged
merged 1 commit into from Jan 24, 2020
Merged

iputils: Increase the priority to avoid collisions with inetutils #78408

merged 1 commit into from Jan 24, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Jan 24, 2020

The ping binary will be from iputils anyway since it's installed in
/run/wrappers/bin/ (first in $PATH) and tftpd will be from iputils as
well since inetutils installs it into libexec (not in $PATH).

Therefore, there's not even a real choice here (though we should most
likely prefer iputils anyway).

Current collisions:
collision between /nix/store/...-iputils-20190709/bin/ping' and /nix/store/...-inetutils-1.9.4/bin/ping'
collision between /nix/store/...-iputils-20190709/share/man/man8/tftpd.8.gz' and /nix/store/...-inetutils-1.9.4/share/man/man8/tftpd.8.gz'

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
iputils: Increase the priority to avoid collisions with inetutils
f4135f3 
The ping binary will be from iputils anyway since it's installed in
/run/wrappers/bin/ (first in $PATH) and tftpd will be from iputils as
well since inetutils installs it into libexec (not in $PATH).

Therefore, there's not even a real choice here (though we should most
likely prefer iputils anyway).

Current collisions:
collision between `/nix/store/...-iputils-20190709/bin/ping' and `/nix/store/...-inetutils-1.9.4/bin/ping'
collision between `/nix/store/...-iputils-20190709/share/man/man8/tftpd.8.gz' and `/nix/store/...-inetutils-1.9.4/share/man/man8/tftpd.8.gz'
@primeos primeos merged commit 24b7d0d into NixOS:master Jan 24, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 24, 2020
@primeos @dtzWill
iputils: Increase the priority to avoid collisions with inetutils (Ni…
55a3f0a 
…xOS#78408)

The ping binary will be from iputils anyway since it's installed in
/run/wrappers/bin/ (first in $PATH) and tftpd will be from iputils as
well since inetutils installs it into libexec (not in $PATH).

Therefore, there's not even a real choice here (though we should most
likely prefer iputils anyway).

Current collisions:
collision between `/nix/store/...-iputils-20190709/bin/ping' and `/nix/store/...-inetutils-1.9.4/bin/ping'
collision between `/nix/store/...-iputils-20190709/share/man/man8/tftpd.8.gz' and `/nix/store/...-inetutils-1.9.4/share/man/man8/tftpd.8.gz'

(cherry picked from commit 24b7d0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos