fish: fix systemctl completion #78422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, typing a command starting with systemctl would result in an
error:
Integer 243 in '243 (243)' followed by non-digit
Link: fish-shell/fish-shell#5689
|
Exactly the same, this one has a better comment, let’s merge that. |
Profpatsch
approved these changes
Jan 26, 2020
|
Except #77951 has already been merged...
|
|
Is this a problem? Just rebase and merge. |
Resolved in private conversation: This was based on a misunderstanding, and #77951 is the preferred one. They both contain the same information—save for the note of what release is expected to contain this—but split differently across the nixpkgs tree and the commit message. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Previously, typing a command starting with systemctl would result in an
error:
Link: fish-shell/fish-shell#5689
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)