Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mc: /bin/rm does not exist #78349

Merged
merged 1 commit into from Jan 27, 2020
Merged

mc: /bin/rm does not exist #78349

merged 1 commit into from Jan 27, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

mcview tries to clean up after itself by running /bin/rm on a temporary script. That obviously doesn't work for us.

The noise is due to nixpkgs-fmt.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from svanderburg January 23, 2020 09:30
mkaito
mkaito approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@mkaito mkaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would probably have been nice to have run nixpkgs-fmt in a separate commit.

@peterhoeg peterhoeg merged commit 291dac4 into NixOS:master Jan 27, 2020
@peterhoeg peterhoeg deleted the fix_mc branch January 27, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaito mkaito mkaito approved these changes

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @mkaito