Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fluidasserts: 20.1.28253 -> 20.1.33141 #78401

Merged
merged 3 commits into from Jan 24, 2020
Merged

pythonPackages.fluidasserts: 20.1.28253 -> 20.1.33141 #78401

merged 3 commits into from Jan 24, 2020

Conversation

kamadorueda
Copy link
Member

@kamadorueda kamadorueda commented Jan 24, 2020 •
edited

Motivation for this change

this version includes some terraform checks and frees the hard dependency on specific versions of azure packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[nix-shell:~/Documents/nixpkgs]$ nix-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
From https://github.com/NixOS/nixpkgs
 * [new branch]              master     -> refs/nixpkgs-review/0
$ git worktree add /home/kamado/.cache/nixpkgs-review/rev-5e4870a0040bfd76f2b0b43120662e7ceb5e0c3d/nixpkgs 385b9aee085b6c5af25f843eb577b14d2b029748
Preparing worktree (detached HEAD 385b9aee085)
HEAD is now at 385b9aee085 Merge pull request #78338 from r-ryantm/auto-update/qtutilities
$ nix-env -f /home/kamado/.cache/nixpkgs-review/rev-5e4870a0040bfd76f2b0b43120662e7ceb5e0c3d/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 5e4870a0040bfd76f2b0b43120662e7ceb5e0c3d
Updating 385b9aee085..5e4870a0040
Fast-forward
 pkgs/development/python-modules/azure-storage-file-share/default.nix | 41 ++++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/fluidasserts/default.nix             | 25 +++++++++++++++--------
 pkgs/development/python-modules/pyhcl/default.nix                    | 46 +++++++++++++++++++++++++++++++++++++++++++
 pkgs/top-level/python-packages.nix                                   |  4 ++++
 4 files changed, 108 insertions(+), 8 deletions(-)
 create mode 100644 pkgs/development/python-modules/azure-storage-file-share/default.nix
 create mode 100644 pkgs/development/python-modules/pyhcl/default.nix
$ nix-env -f /home/kamado/.cache/nixpkgs-review/rev-5e4870a0040bfd76f2b0b43120662e7ceb5e0c3d/nixpkgs -qaP --xml --out-path --show-trace --meta
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/kamado/.cache/nixpkgs-review/rev-5e4870a0040bfd76f2b0b43120662e7ceb5e0c3d/build.nix
[1/1/3 built, 0.0 MiB DL] building python3.7-fluidasserts-20.1.33141 (installCheckPhase): test/test_cloud_aws_cloudform * [new branch]              master     -> refs/nixpkgs-review/0
[3 built, 0.0 MiB DL]
4 package built:
fluidasserts python37Packages.azure-storage-file-share python37Packages.pyhcl python38Packages.pyhcl

jonringer
jonringer reviewed Jan 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/python-modules/azure-storage-file-share/default.nix Show resolved Hide resolved
@kamadorueda
Copy link
Member Author

I have two questions, not directly related to this PR:

is there a way one could add tests that require network connectivity ?

what happens if my package depends on OS things like postgresql etc ? can I add them to propagatedBuildInputs ?

@jonringer
Copy link
Contributor

jonringer commented Jan 24, 2020 •
edited

is there a way one could add tests that require network connectivity ?

If the connectivity is local, then yes. If you need the internet, no; that would hinder reproducibility of the builds.

what happens if my package depends on OS things like postgresql etc ? can I add them to propagatedBuildInputs ?

If you need the postgres libraries, that would be a build input. If you want call something like psql at runtime, then that would be done with wrapping the executables. If you wanted postgres to be called while just being a "module", then you need to patch the source code so it calls the executable directly.

@jonringer
Copy link
Contributor

you would probably be interested in https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/pyproj/default.nix I patched the calling of the executable like so: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/pyproj/001.proj.patch

@kamadorueda
Copy link
Member Author

is there a way one could add tests that require network connectivity ?

If the connectivity is local, then yes. If you need the internet, no; that would hinder reproducibility of the builds.

what happens if my package depends on OS things like postgresql etc ? can I add them to propagatedBuildInputs ?

If you need the postgres libraries, that would be a build input. If you want call something like psql at runtime, then that would be done with wrapping the executables. If you wanted postgres to be called while just being a "module", then you need to patch the source code so it calls the executable directly.

cool! just found the way to add tests for the mock servers! will do that in another PR though

@jonringer
Copy link
Contributor

cool! just found the way to add tests for the mock servers! will do that in another PR though

If it's a series of services (E.g. nextcloud + redis + postgres), generally these tests are written as nixos tests, which allow for simulation of many machines talking to each other.

jonringer
jonringer approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[8 built, 3 copied (10.1 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78401
4 package built:
fluidasserts python37Packages.azure-storage-file-share python37Packages.pyhcl python38Packages.pyhcl

@jonringer jonringer merged commit 52487f4 into NixOS:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamadorueda @jonringer