Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/amazon-init.nix: add git/tar/gz, fix AMI configuration #78363

Merged
merged 4 commits into from Jan 23, 2020
Merged

nixos/amazon-init.nix: add git/tar/gz, fix AMI configuration #78363

merged 4 commits into from Jan 23, 2020

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

  • When you specify custom channels in the AWS userdata, using a .tar.gz, or it uses fetchGit, the update will fail. Nix (still) requires these tools at runtime.

  • Pass the configuration through the AMI generation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yorickvP yorickvP mentioned this pull request Jan 23, 2020
Merged
10 tasks
mkaito
mkaito approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@mkaito mkaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've already been using this in production for a little bit, and it works well.

@mkaito
Copy link
Contributor

mkaito commented Jan 23, 2020

Passing configuration is useful to prepopulate AMIs with useful things (default users, default substituters) and to set system label and AMI name for upload to AWS (we suffix it with -serokell for identification, and also incorporate a second git ref for the repo that contains the wrapping AMI config.

infinisil
infinisil approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@infinisil infinisil merged commit 3a4e550 into NixOS:master Jan 23, 2020
@tomberek tomberek mentioned this pull request Apr 14, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaito mkaito mkaito approved these changes

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yorickvP @mkaito @infinisil