New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mopidy-mpris: init at 3.0.1 mopidy-somafm: init at 2.0.0 mopidy-youtube: 2.0.2 -> 3.0 mopidy-gmusic: 3.0.0 -> 4.0.0 #78361
Conversation
I'm really happy to see this, have been waiting for somebody to do that! Thank you for taking the time to update this. This works for Mopidy-Youtube:
So my uneducated guess is that there is a problem with the way beautifulsoup is packaged. Alternatively, we can submit an issue upstream asking whether |
@GrahamcOfBorg build mopidy mopidy-gmusic mopidy-youtube mopidy-mpd mopidy-mpris mopidy-somafm |
Also I believe it's better to have a separate commit for each package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct, each package addition and bump should be a separate commit, so 7 in total
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please take a look at package failures:
[15 built (6 failed), 14 copied (20.9 MiB), 4.6 MiB DL]
error: build of '/nix/store/gznv1kjf542cb5dv02dl5ayx3jffwjyf-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/78361
7 package failed to build:
mopidy-moped mopidy-mopify mopidy-musicbox-webclient mopidy-soundcloud mopidy-spotify mopidy-spotify-tunigo mopidy-youtube
8 package built:
mopidy mopidy-gmusic mopidy-mpd mopidy-mpris mopidy-somafm python27Packages.pykka python37Packages.pykka python38Packages.pykka
most have similar error:
Processing ./Mopidy_Spotify-3.1.0-py2.py3-none-any.whl
ERROR: Could not find a version that satisfies the requirement Mopidy>=2.0 (from Mopidy-Spotify==3.1.0) (from versions: none)
ERROR: No matching distribution found for Mopidy>=2.0 (from Mopidy-Spotify==3.1.0)
Right, these are the mopidy plugins which I didn't update (except |
unfortunately, you cannot have different versions of the same package in The other option would be to disable the other packages, however, I don't like the idea of adding packages that are already broken. |
I think you might be misunderstanding me a little - mopidy has migrated to python3, and as such it does not support python2 plugins any more. The plugins which still work have been rewritten/migrated to python3. But many plugins have not been migrated, and I think that we should just remove them |
needs a rebase |
If there's no plan to migrate the broken plugins, then please remove. Otherwise you can just mark them broken until they are in a usable state. I would just really like for package evaluation reflect the current condition of the package |
At least spotify-tunigo can be marked as broken without too much thinking: upstream project is deprecated, and most features are now implemented in the mopidy-spotify plugin. |
I can't figure out how to get |
Sorry, I really let this one wither a bit - I updated, rebased, and trimmed off the bits that got merged into other PRs, so I think this ought to be good to merge now |
@balsoft I just set up a new instance of mopidy, and did a
|
@GrahamcOfBorg build mopidy-gmusic mopidy-youtube mopidy-mpris mopidy-somafm |
@NickHu oh, now it works for me too. I guess I have somehow messed up something last time I tried it ;) |
@balsoft @jpotier @jonringer @FRidh Any remaining objections or should I merge this? |
Can't wait for it to be merged, one more hacky overlay removed from my config! Thank you very much for this once again! |
Result of 3 packages built:- mopidy-mpris - mopidy-somafm - mopidy-youtube |
mopidy-gmusic: 3.0.0 -> 4.0.0
mopidy-mpris: init at 3.0.1
mopidy-somafm: init at 2.0.0
mopidy-youtube: 2.0.2 -> 3.0.0
Motivation for this change
This changeset moves mopidy onto the python3 branch (the python2 version is EOL), and updates some plugins. Note thatThis was merged in a different PR.mopidy-mpd
was bundled with mopidy previously, but has been extracted into its own plugin in this release.This PR is slightly WIP as in I cannot figure out how to getFixed by @balsoft's comment below.mopidy-youtube
to build; any help debugging this build error would be appreciated.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)