Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.gsconnect: 30 -> 31 #78359

Merged
merged 1 commit into from Jan 24, 2020
Merged

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Jan 23, 2020

Motivation for this change

No longer depends on libfolks 馃帀

https://github.com/andyholmes/gnome-shell-extension-gsconnect/releases/tag/v31:

Notable Fixes

Fix notification not shown when payloadTransferInfo is empty (#745, by @R1tschY) trophy
Fix undefined/missing addresses (#738, by @ofuangka)
Fix themed icon fallbacks in GNOME Shell (#726, with help from @jnsh) trophy
Aggressive unpairing on authentication failure (see f736783)
Replace libfolks with evolution-data-server for Desktop Contacts (#728)

I'm getting some gi errors from nautilus not being able to load the python nautilus extensions, but that looks like a problem with nautilus as I'm getting the same errors when launching from eg. terminal.

Things done

Running it successfully in my session now. Checked that contacts works correctly.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jan 23, 2020
@ofborg ofborg bot requested a review from etu January 23, 2020 13:06
@hedning hedning merged commit 93c7301 into NixOS:master Jan 24, 2020
@hedning hedning deleted the gsconnect-31 branch February 3, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants