Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-rebar3: restore rebar3-nix-bootstrap path #78418

Merged
merged 1 commit into from Jan 30, 2020
Merged

build-rebar3: restore rebar3-nix-bootstrap path #78418

merged 1 commit into from Jan 30, 2020

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

buildRebar3 broke in #71393, this should fix it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yorickvP
Copy link
Contributor Author

cc: @cw789 @DianaOlympos @Mic92 @gleber @ankhers @tazjin

@cw789
Copy link
Contributor

cw789 commented Jan 27, 2020

Hey, I'm not a user of buildRebar3, so I can't say much about this one.
But I couldn't find a change in #71393 that would made this needed change obvious to me.

@DianaOlympos
Copy link
Contributor

He is right, the problematic line is https://github.com/NixOS/nixpkgs/pull/71393/files#diff-177ea02978ffc72f964033695c5e023eL8

It may make more sense to revert that line change. Would you mind @yorickvP ? instead of hardcoding a path ?

Long term we probably need to rethink how this work, but one thing at a time.

@yorickvP
Copy link
Contributor Author

Sounds good, will do that later today. This is used inside https://gitlab.com/transumption/mix-to-nix/, which will have to be rewritten in the long run, indeed. Another rebar3 upgrade broke the hex registries anyways.

@yorickvP
Copy link
Contributor Author

Done.

@ofborg ofborg bot requested review from gleber and tazjin January 29, 2020 19:28
@DianaOlympos
Copy link
Contributor

Thanks ! 🚀

@Mic92 Mic92 merged commit 2dfc3e5 into NixOS:master Jan 30, 2020
@yorickvP yorickvP deleted the yorickvp/build-rebar3-fix branch January 30, 2020 16:15
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@Mic92 @anna328p
build-rebar3: restore rebar3-nix-bootstrap path (NixOS#78418)
5439906 
build-rebar3: restore rebar3-nix-bootstrap path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DianaOlympos DianaOlympos DianaOlympos approved these changes

@gleber gleber Awaiting requested review from gleber

@tazjin tazjin Awaiting requested review from tazjin

Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yorickvP @cw789 @DianaOlympos @Mic92