Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snowman: use Qt mkDerivation #78416

Merged
merged 1 commit into from Jan 24, 2020
Merged

snowman: use Qt mkDerivation #78416

merged 1 commit into from Jan 24, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Jan 24, 2020

Motivation for this change

Fixes #78382
For #65399

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@B4dM4n B4dM4n mentioned this pull request Jan 24, 2020
Closed
10 tasks
@B4dM4n B4dM4n requested a review from dtzWill January 24, 2020 14:44
@teto
Copy link
Member

teto commented Jan 24, 2020 

[2 built, 1 copied (23.5 MiB), 2.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78416
1 package built:
snowman

binary looks ok

@teto teto merged commit 82fbe42 into NixOS:master Jan 24, 2020
@B4dM4n B4dM4n deleted the snowman-qt-fix branch January 24, 2020 21:55
@dtzWill
Copy link
Member

dtzWill commented Jan 24, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

snowman is broken due to Qt
3 participants
@B4dM4n @teto @dtzWill