-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
kapow: init at 1.5.10 #78407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kapow: init at 1.5.10 #78407
Conversation
Builded it locally, but execution doesn't work for me:
Also you should make two commits, one for the package, one for adding yourself in maintainers. The commit message for adding the package would be: |
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
kapow is an established name of an older project, being packaged in NixOS#78407. Repology and ArchLinux call the Go project kapowbang because its name is "Kapow!": https://github.com/BBVA/kapow https://repology.org/projects/?search=kapow https://aur.archlinux.org/packages/?K=kapow
Split the maintainers file commit. |
I have set myself as the maintainer because the change to maintainers list seemed invalid: azimov.rocks email domain is not registered and 0x769C79DA5C9B038A PGP key is not published. @0x450x6c, please add yourself to maintainers if you still wish to maintain this package (and be notified of its issues and pull requests that edit its definition). |
What about merge it and include @0x450x6c in a future commit? |
OK. |
Motivation for this change
For add a new package
Things done
Added a new package :)
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)