Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wine: Look for root certs at $NIX_SSL_CERT_FILE #78406

Merged
merged 1 commit into from Jan 30, 2020
Merged

wine: Look for root certs at $NIX_SSL_CERT_FILE #78406

merged 1 commit into from Jan 30, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Jan 24, 2020

Closes #78365

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ dasJ mentioned this pull request Jan 24, 2020
Closed
@dasJ
Copy link
Member Author

dasJ commented Jan 24, 2020

@GrahamcOfBorg build wine wineStaging wineUnstable

@ofborg ofborg bot requested review from 7c6f434c, bendlas and avnik January 24, 2020 11:36
@7c6f434c 7c6f434c merged commit ae929e6 into NixOS:master Jan 30, 2020
@ajs124 ajs124 deleted the wine-certs branch January 30, 2020 22:24
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@7c6f434c @anna328p
Merge pull request NixOS#78406 from helsinki-systems/wine-certs
b24dc04 
wine: Look for root certs at $NIX_SSL_CERT_FILE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@bendlas bendlas Awaiting requested review from bendlas

@avnik avnik Awaiting requested review from avnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLS on wine doesn't work inside the sandbox
2 participants
@dasJ @7c6f434c