Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsniff: Unbreak the build (trivial pull request) #78410

Merged
merged 1 commit into from Jan 24, 2020
Merged

dsniff: Unbreak the build (trivial pull request) #78410

merged 1 commit into from Jan 24, 2020

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Jan 24, 2020

Motivation for this change

On current master, and also on current nixos-unstable-small, the package dsniff is broken (does not build). Adding -ldl to the gcc flags fixes the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from symphorien January 24, 2020 13:32
@iblech iblech changed the title dsniff: Unbreak the build dsniff: Unbreak the build (trivial pull request) Jan 24, 2020
@bjornfor bjornfor merged commit 89864a0 into NixOS:master Jan 24, 2020
@iblech
Copy link
Contributor Author

iblech commented Jan 29, 2020

Thank you @bjornfor for the quick review and merge :-) Very much appreciated. Thank you for your work on NixOS! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien Awaiting requested review from symphorien

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iblech @bjornfor